Arcadia-Science / arcadia-pycolor

Python package for styling plots according to Arcadia's style guide
MIT License
4 stars 0 forks source link

Add color vision deficiency, gradient, and palette display tools #20

Closed mezarque closed 3 months ago

mezarque commented 3 months ago

PR checklist

Overview

This PR adds functionality for simulating color vision deficiency under the cvd module.

In addition, this PR adds some helpful utilities to the Palette and Gradient classes:

Testing

I confirmed that these functions work using usage_example.ipynb, where you can also see how these methods are meant to be used.

Not addressed

We are still finalizing the gradients, palettes, and font sizes, etc.; those changes will come in a future PR, including better names for unidirectional and bidirectional gradients. We're also working on making sure we have standardized sizing/ naming for plot sizes which can be drag/drop placed into Illustrator templates.

I also have not written tests for the mpl module or this new functionality yet... would love some help to do this if anyone has bandwidth.

Halp

Would love feedback on the naming and structure of things! I think we can be generally afford to be more verbose / less intuitive with some of the cvd stuff, since it's meant to be used primarily by color-obsessives like myself and Audrey.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB