Closed keithchev closed 1 week ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@mezarque I made one minor change after you reviewed to add numpy
as an explicit dependency. Since numpy was already a transitive dependency (of matplotlib), nothing was broken, but because some apc
modules import numpy
, it's good to include it among the direct deps.
The documentation for the package currently consists of a series of jupyter notebooks. This PR:
docs/
subdirectory.Note: github does not recognize that the
style_usage.ipynb
notebook was moved; it treats it as a new file, so there's no way to view the diff, which is annoying. (I was careful to move the file in one commit and modify it in a second commit, so the git history "knows" about the renaming; this must be a github thing).Other changes
/plot_testing
into/docs/examples
.style_usage
notebook.style_usage
notebook for clarity/succinctness.ipykernel
from a main dependency to a dev dependency (as it is only needed to run the documentation notebooks).Style changes
These were made in discussion with Dennis.
mpl.style_axis
tostyle_plot
for clarity.lightgray
togray
to be consistent with the style guide. -renamebrown_shades
towarm_gray_shades
andgrey_shades
tocool_gray_shades
.PR checklist
conda
environments.