search

Arcadia-Science / glial-origins

Evolutionary origins and relationships of glial cell types
MIT License
2 stars 0 forks source link

get_from_url needs a valid exception #40

Closed jasegehring closed 1 year ago

jasegehring commented 1 year ago

the get_from_url function in the biofile_handling.py script has an invalid exception when the output path exists. Not sure what the desired behavior is here, maybe just an error message?

mezarque commented 1 year ago

Currently, if the path exists, the get_from_url method should return the BioFile object. Usually get_from_url is called automatically if you pass url and protocol on file initialization. We could rework it so that you have to explicitly call get_from_url after you make the BioFile object if that is more intuitive.

Do you have an example of what exception is raised when you've used it?

mezarque commented 1 year ago

I'm marking this as resolved, as I made modifications to get_from_url() that should cover corner cases.