search

Arcadia-Science / metagenomics

A Nextflow workflow for QC, evaluation, and profiling of metagenomic samples using short- and long-read technologies
MIT License
34 stars 2 forks source link

Github CI tests #33

Closed elizabethmcd closed 1 year ago

elizabethmcd commented 1 year ago

This PR adds support for Github CI for linting checks and tests of both the Illumina and Nanopore workflows. Review #31 before this PR.

elizabethmcd commented 1 year ago

I can't confirm if these will work I think until they are merged and then run the tests on future commits?

mertcelebi commented 1 year ago

@elizabethmcd can you fix this PR so it only has the GitHub CI changes and not the changes from your other PR?

elizabethmcd commented 1 year ago

I have fixed the PR so it doesn't have the files from the previous PR to re-review. I've also changed the awstest.yml test to have just the test_illumina profile. I've looked at other nf-core workflows that are similarly setup with two separate "subworkflows" and they have a general test profile that really only tests one of the subworkflows for this purpose. In the future it would be nice to test both, but for the purposes of getting this up and going I think this is fine.