Arcadia-Science / peptigate

Peptigate ("peptide" + "investigate") predicts bioactive peptides from transcriptome assemblies or sets of proteins.
MIT License
1 stars 1 forks source link

Refactor to reduce duplication when there is only protein as input #40

Closed taylorreiter closed 6 months ago

taylorreiter commented 6 months ago

Note that this PR is against the branch in #39, which has already been approved. The changes were substantial enough that I did them in another branch. Once this one passes review, I intend to merge into #39 and then merge #39 w/o additional review.

PR checklist

Issues or milestones

PR description

This PR refactors extract_deeppeptide_sequences.py and run_nlpprecursor.py so that these scripts can be used when there is only protein or protein & nucleotide inputs. In #39, I had duplicated the scripts. This removes that duplication.

Tests

For the deeppeptide script, I checked by eye that the results were correct. Learning my lesson, I then compared md5sums for the nlpprecursor to make sure that the outputs were the same before and after the refactor.

Other

taylorreiter commented 6 months ago

Thank you so much @keithchev! I addressed all of your feedback and made sure I still get the same results after the changes. merging now!