Open taylorreiter opened 1 year ago
called in nextflow module using (untested):
container "${ workflow.containerEngine == 'docker' ? 'taylorreiter/20221209-multiqc-sourmash:b8ea142':
'' }"
small comment as I think you'll do this anyway - put the dockerfile for this and the documentation described above in the workflow repo itself as well
i don't have a docker file, there is no docker file output by this approach.
ah ok I think I haven't come upon this approach before where you commit changes to an existing docker image - so this is doing all of this without creating a Dockerfile like when you create a docker image from scratch? this is nifty
courtesy of @austinhpatton! currently failing CI because of platform things, but i'll fix it soon :)
Documenting docker installation on linux ubuntu to fix the platform issue (followed these instructions https://docs.docker.com/engine/install/ubuntu/):
prep for docker install:
sudo apt-get update
sudo apt-get install \
ca-certificates \
curl \
gnupg \
lsb-release
sudo mkdir -p /etc/apt/keyrings
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu \
$(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
Install the docker engine
sudo apt-get update
sudo apt-get install docker-ce docker-ce-cli containerd.io docker-compose-plugin
sudo docker run hello-world
Allow login
sudo chmod 666 /var/run/docker.sock
Just dropping a note here, in the future, we should include Dockerfiles for Docker images we're sharing, so others can easily replicate + extend as needed.
This shouldn't be a big issue, because presumably there will be a more formal docker image for multqc-sourmash
, is that the right assumption @taylorreiter ?
yes! once the sourmash PRs are merged into multiqc, we'll use the conda/biocontainer/quay.io image for multiqc.
I implemented new sourmash multiqc modules. I would like these to be integrated into the seqqc pipeline now, but I'm guessing there will be substantial lag time between 1) PRs being merged into multiqc 2) a new conda release of multiqc 3) a new biocontainers docker for the new conda release of multiqc.
So in the meantime, I'm creating a temporary docker container that will have multiqc installed from my branch, github.com/taylorreiter/MultiQC branch ter/add-sourmash-gather (which was branched from ter/add-sourmash-compare and so has both).
I built the docker container using these instructions: https://phoenixnap.com/kb/how-to-commit-changes-to-docker-image
Image shared on docker hub using the following instructions: https://docs.docker.com/get-started/04_sharing_app/
Available here: https://hub.docker.com/repository/docker/taylorreiter/20221209-multiqc-sourmash