search

Arcadia-Science / seqqc

A Nextflow pipeline to identify quality control issues with new sequencing data.
MIT License
28 stars 0 forks source link

Move nf-core-modified out of local for better visual hierarchy #33

Closed mertcelebi closed 1 year ago

mertcelebi commented 1 year ago

Feel free to reject this change. We made this change for the phylorthology pipeline and I think it makes things a little bit clearer.

mertcelebi commented 1 year ago

ugh, nf-core lint fails... i am sure there's a way to fix that, but I'll only do it if you think this change is worthwhile.

taylorreiter commented 1 year ago

i like the organization/better visibility if it passes the linter!

elizabethmcd commented 1 year ago

I previously tried an organizational change like this and not only will it fail the linter, but if you try to add modules with nf-core modules install <MODULE> later on it will fail because it doesn't recognize the nf-core-modified directory in the modules directory, so I put it back into local.

taylorreiter commented 1 year ago

Ah that's great insight Elizabeth. I suggest we abandon ship and leave it as it is now then.

mertcelebi commented 1 year ago

Closing since we should probably use nf-core modules patch for this stuff.