Arcadia-Science / sourmashconsumr

Working with the outputs of sourmash in R
https://arcadia-science.github.io/sourmashconsumr/
Other
21 stars 3 forks source link

Functions to plot the output of `sourmash taxonomy annotate` #23

Closed taylorreiter closed 1 year ago

taylorreiter commented 1 year ago

Inspired by the upset plot here: https://github.com/Arcadia-Science/2022-prjna853785-sourmash/blob/main/notebooks/20220815-visualize-sourmash-taxonomy-results.ipynb

Improvements include coloring the intersections bars by taxonomic level and optional taxonomic agglomeration to any taxonomic rank.

I did some refactoring in this PR too -- the few files where you see whole functions or tests disappearing actually went into different files. The metacoder stuff was simplified when I pulled out the tax agglomeration stuff to it's own function. I also wrote a bunch of utility functions for working with upset plots. These will work on any upset compliant data frame, not just the ones made in this package, so I thought they should all be pulled out and placed together and tested together.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@00e1e57). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ======================================= Coverage ? 79.00% ======================================= Files ? 5 Lines ? 281 Branches ? 0 ======================================= Hits ? 222 Misses ? 59 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.