Arcadia-Science / sourmashconsumr

Working with the outputs of sourmash in R
https://arcadia-science.github.io/sourmashconsumr/
Other
25 stars 3 forks source link

switch `tax_glom*`/agglomeration language to aggregate #28

Open taylorreiter opened 2 years ago

taylorreiter commented 2 years ago

@elizabethmcd pointed out in #23:

This might just be a personal thing, but the term agglomeration and referring to the function tax_glom_taxonomy_annotate seems a little confusing and maybe doesn't clearly convey what this function is doing. I think in R the similar but more known action is aggregating and people might be more familiar with this? Up to you.

I was copying the syntax/naming of the phyloseq function that does this: https://rdrr.io/bioc/phyloseq/man/tax_glom.html

I wanted to record this feedback because if we keep getting it then I want to change the wording for the function.