Arcadia-Science / sourmashconsumr

Working with the outputs of sourmash in R
https://arcadia-science.github.io/sourmashconsumr/
Other
25 stars 3 forks source link

Code fixes and new tests for problems I discovered when writing the vignette #48

Closed taylorreiter closed 2 years ago

taylorreiter commented 2 years ago

These are all super random...sorry. I lumped them into one PR because I needed these changes to keep making progress on the vignette. This should be reviewed before #46.

For all of the bugs that I found that were not in plotting code, I added a test that would catch the bug to fend off the same thing re-occurring in the future. For bugs in plotting code (like the axis having the wrong label), I didn't because it's really hard to test plotting code above asking, "does this make a plot?"

The "closed" flags also document the issues that this PR addresses.

codecov-commenter commented 2 years ago

Codecov Report

Base: 91.41% // Head: 91.55% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (b0c1abd) compared to base (e1c45b5). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 91.41% 91.55% +0.14% ========================================== Files 8 8 Lines 524 533 +9 ========================================== + Hits 479 488 +9 Misses 45 45 ``` | [Impacted Files](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science) | Coverage Δ | | |---|---|---| | [R/from\_taxonomy\_annotate\_to\_metacoder.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9mcm9tX3RheG9ub215X2Fubm90YXRlX3RvX21ldGFjb2Rlci5S) | `82.00% <100.00%> (+1.14%)` | :arrow_up: | | [R/plot\_gather.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9wbG90X2dhdGhlci5S) | `98.18% <100.00%> (ø)` | | | [R/plot\_signatures.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9wbG90X3NpZ25hdHVyZXMuUg==) | `79.41% <100.00%> (+0.30%)` | :arrow_up: | | [R/plot\_taxonomy\_annotate.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9wbG90X3RheG9ub215X2Fubm90YXRlLlI=) | `92.95% <100.00%> (-0.05%)` | :arrow_down: | | [R/read\_sourmash\_outputs.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9yZWFkX3NvdXJtYXNoX291dHB1dHMuUg==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.