Arcadia-Science / sourmashconsumr

Working with the outputs of sourmash in R
https://arcadia-science.github.io/sourmashconsumr/
Other
21 stars 3 forks source link

Update the plot codes and examples so that the plot look can be maniuplated more easily to achieve a specific look #66

Closed taylorreiter closed 1 year ago

taylorreiter commented 1 year ago

Megan had a bunch of recommendations/requests on the figures for the sourmashconsumr pub. For a lot of them, I would need to update the source code of sourmashconsumr to achieve the look she asked for. This PR updates the source code so all of the changes she asked for can be made directly to the default plots that are output by sourmashconsumr by adding more layers or parameters to the plot.

Ready for review once checks all pass.

codecov-commenter commented 1 year ago

Codecov Report

Base: 91.86% // Head: 92.02% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (51920ac) compared to base (a983a4d). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== + Coverage 91.86% 92.02% +0.15% ========================================== Files 8 8 Lines 615 627 +12 ========================================== + Hits 565 577 +12 Misses 50 50 ``` | [Impacted Files](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science) | Coverage Δ | | |---|---|---| | [R/plot\_gather.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9wbG90X2dhdGhlci5S) | `98.46% <100.00%> (ø)` | | | [R/plot\_signatures.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9wbG90X3NpZ25hdHVyZXMuUg==) | `80.55% <100.00%> (ø)` | | | [R/plot\_taxonomy\_annotate.R](https://codecov.io/gh/Arcadia-Science/sourmashconsumr/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science#diff-Ui9wbG90X3RheG9ub215X2Fubm90YXRlLlI=) | `93.36% <100.00%> (+0.40%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arcadia-Science)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.