search

Arcana / dotabank-web

dotabank.com
8 stars 6 forks source link

Lobby type 0 is rendering as "Invalid" #1

Closed rjackson closed 10 years ago

rjackson commented 10 years ago

Should be public matchmaking

Test case: http://dotabank.com/replays/694628474/

Smashman commented 10 years ago

Did they change AP to 0, then? Protobuffs clearly still say that 0 is none: https://github.com/SteamRE/SteamKit/blob/master/Resources/Protobufs/dota/dota_gcmessages_common.proto#L432

rjackson commented 10 years ago

Game mode is fine. Lobby type 0 is "Public matchmaking", but our code is broke and displays it as invalid.

Problem is our end, not volvos end.

Smashman commented 10 years ago

I was confused and looked at wrong thing. How long has this been present?

Smashman commented 10 years ago

I'm guessing since https://github.com/Arcana/dotabank-web/commit/42c6b0085217511d493af4d3e9d09bd3e14cdc2b which also implies that the gamemode one is wrong, it just doesn't appear as such due to 0 being Invalid anyway