F-Droid can't build

[licaon-kter]

ref: https://monitor.f-droid.org/builds/log/chat.delta.lite/300006914#site-footer 2024-10-07 01:29:04,488 ERROR: Found usual suspect 'com.google.gms' at build.gradle

so I remove that line here https://github.com/ArcaneChat/android/blob/v1.46.20/build.gradle#L3 and here https://github.com/ArcaneChat/android/blob/v1.46.20/build.gradle#L129

but now it's not repro any more, here is the diff log: chat300006924.log

what did I miss?

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/1424de9b3b55d70f3c8f136439d942623835687e

[adbenitez]

@licaon-kter what about fixing the detector? it is just wrong, com.google.gms dep is added only for gplay flavor so the checker should check for implementation and fossImplementation (the flavor used by f-droid)

EDIT: ah it is about the plugin, I can't remove that and I think the plugin itself is open source 🤷‍♂️

[licaon-kter]

what about fixing the detector?

indeed the scanner is not a scalpel, but more like a hammer :laughing:

ah it is about the plugin, I can't remove that and I think the plugin itself is open source 🤷‍♂️

we don't care what you put in THAT flavor.

do read the diff log, notice how your FOSS APKs still have "google" strings references?

[adbenitez]

do read the diff log, notice how your FOSS APKs still have "google" strings references?

what diff log? I read the log you pointed out and all it says is ERROR: Found usual suspect 'com.google.gms' at build.gradle so there is no closed source in the FOSS variant, it is only about the build.gradle containing com.google.gms.google-services gradle plugin WHICH IS OPEN SOURCE under Apache License 2.0

so I don't think there is anything to be fixed here in this repo but in fdroid machinery???

(also this was working just fine for the previous version, I didn't make any change in that area, so it seems the scanner was "improved" and a bug was introduced)

[licaon-kter]

@adbenitez are we lost in translation?

you say that you don't see the chat300006924.log diff log that I attached in the OP? :eye:

[adbenitez]

you say that you don't see the chat300006924.log diff log that I attached in the OP? 👁️

what has that file to do with the problem of the false positive? that file is about a failure due to some changes you made in the gradle.build

I don't see any point into trying to debug that and that they are not the same with/without the plugin is kind of expected since the plugin generates some files

we should focus in the fact that the plugin is free software and there is no point into failing build because of it

[licaon-kter]

Two questions then

https://github.com/ArcaneChat/android/blob/v1.46.20/build.gradle#L3 is this free software too? If not, can I remove it?

https://github.com/ArcaneChat/android/blob/v1.46.20/build.gradle#L129 if I don't build this flavor, why can't I remove this line?

[adbenitez]

https://github.com/ArcaneChat/android/blob/v1.46.20/build.gradle#L3 is this free software too? If not, can I remove it?

I already said here that it is perfectly fine Apache 2.0 free software

https://github.com/ArcaneChat/android/blob/v1.46.20/build.gradle#L129 if I don't build this flavor, why can't I remove this line?

you can remove that line, what you can't remove is the plugin line you mentioned in your previous question, but there is no point in removing it and sed-ing in the build.gradle in this case since it is another flavor

[adbenitez]

I opened an issue about the actual problem of detecting a free software gradle plugin as closed source and invalidating the building process here: https://gitlab.com/fdroid/fdroid-suss/-/issues/16

[adbenitez]

fixed by https://gitlab.com/fdroid/fdroid-suss/-/commit/f986a6386254b9f3cf6dc645ac453debe7e2b5e6

[licaon-kter]

confirmed ok: https://gitlab.com/fdroid/fdroiddata/-/commit/c47552498ec602acc5eacb7999b4804695eabca7

thanks

sorry for my confusion :smile_cat: