search

ArcanePariah / Night-of-the-Dead

10 stars 14 forks source link

Gunship (Asgard) Transient #156

Closed ThunderRazor closed 6 years ago

ThunderRazor commented 6 years ago

PATCH NOTE: Gunship (Asgard) is transient.

PURPOSE OF PATCH: If the Forward Observer player is not following anyone (no -gbuddy) then he/she may choose to hold position or continue to manually follow a unit thru click-follow (a.k.a. "scan-move") without interruption.

NiktosNOTD commented 6 years ago

Are you sure it works the way you think it does? Coz if you don't set -gbuddy it simply autopicks closest marine, is your change going to cleanly overwrite that autobuddy or lead to fo getting two possibly conflicting move commands?

ThunderRazor commented 6 years ago

If there be triggers that command the FO to follow the closest marine, then so be it. In this patch, I only enabled two flags (allow movement and transient) so that clicking on the Asgard skill button does not replace current actions. I tested this to where I -gbuddy myself, hold position, and then activate Asgard. My hold position was successfully preserved. According to the descriptions (or tooltips), -gbuddy yourself is supposed to keep you still (prevent you from moving around), but that does not happen in practice because Asgard was not transient. If the -gbuddy yourself fails to preserve hold position (or fails to preserve existing order (eg. "scan move")) in multiplayer, then I would need to do some troubleshooting of the triggers to fix that. In summary, transient Asgard only affects whether Asgard overwrites existing orders upon activation; it does not affect trigger actions that happen after that.

On a similar note, I'm still working on rebuilding the gunship support triggers (which include that auto-buddy stuff). My guess is that I'm only halfway at the moment.