ArcanePariah / Night-of-the-Dead

9 stars 14 forks source link

Fixing kills made by barrel explosions to grant xp. #221

Closed NiktosNOTD closed 6 years ago

NiktosNOTD commented 6 years ago

So kills made by barrels had multiple problems.

It's only for BarrelKills trigger. Didn't find a way to optimize the Barrels trigger First off - Event for it fired on every single unit death. image Second - conditions were set up wrong so it was never even running, always failing. Third - Actions within trigger were not giving xp for kill, only adding the kill to full 'Kill count' score. (but it never ran anyway) Fourth - it didn't account for situations where zombie killed the barrel and units near with it. (for ex. titan splash can kill barrel, so do banelings/beastings, agron splash can also kill barrels) Fifth it didn't take into account that sometimes marine/predator of player can be dead but his summons can still kill barrels.

Here is a report i made in 2013, when barrels were still giving xp as seen by screenshots of point 4.

My changes do: 1.Change event to be precise 2.Check if killer is a player 3.Check if either marine or predator are alive 4.Grant xp to marine if he lives, or predator if marine is dead.