search

ArcanePariah / Night-of-the-Dead

9 stars 14 forks source link

Problem with learning abilities sometimes take 2. [tested and works] #244

Closed NiktosNOTD closed 6 years ago

NiktosNOTD commented 6 years ago

It's pull #205 but improved to not apply to just cutscenes/forcepush but to all potential stuff. AND this time working as in previous pull it didn't.

This time with a "is ability enabled" condition i was not aware is an option.

Also with an OR so it actually works instead of just being there.

NiktosNOTD commented 6 years ago

So i won't have time to re-check it today. In case you want to get a patch going just ignore this pull for now.

NiktosNOTD commented 6 years ago

So fixed the problem you pointed out about 'GenericMarineLearn'

As result changed non working test of 'GenericMarineLearn' being disabled into a condition definition which tests for all possible class assigned learn abilities. While new condition def is just a list of abilities under 'or' and could just be copied directly into conditions it staying separate is good for not cluttering code visually.

This time tested fully and confirmed to work as intended.