search

ArcanePariah / Night-of-the-Dead

9 stars 14 forks source link

Ap ammo unwanted debuff during charge fix - v2 Charge NOT applying safeguard. #251

Closed NiktosNOTD closed 5 years ago

NiktosNOTD commented 6 years ago

The Bug: Charge of assault WITH 'ap ammo' modification equiped applies debuff to assault himself, and also builds up stacks of "safeguard" if he has the skill. Normal usages of charge do not apply "safeguard" charges in live game. The Why: charge_why

The fix v2: Usage of assault charge now NEVER applies stack of safeguard. Having ap equiped also now never applies debuff on charging assault.

Due to actors/sounds associated with charge relying on existence of this effect it retains it's name with just being changed to a blank "ModifyUnit" effect instead of "Damage" one, it prevents it's unwanted interactions with 'ap ammo' without changing anything else.

NiktosNOTD commented 6 years ago

Just pick one between #250 and #251

I believe #251 is how it was in the past and it would be my pick but i'm not sure and both were pretty trivial changes so anything goes.