search

ArcanePariah / Night-of-the-Dead

9 stars 14 forks source link

Plasma visual stuck fix - maybe #271

Closed NiktosNOTD closed 5 years ago

NiktosNOTD commented 5 years ago

Sometimes engy plasma charge circle stays on screen forever, i believe it's due to animation getting omitted by sc2 engine, similiar to how sometimes mm gets stuck mid osok or mando slides after gravnade.

Going by this assumption tying actor destruction to animation running it's course was the problem, so i changed it to get tied to actor age,

If it fixes plasmas getting stuck then that's cool, if it does not - it still functionally does same thing

dave-sWpR46Ae commented 5 years ago

https://github.com/dave-sWpR46Ae/Night-of-the-Dead/commit/6bb9981c85b59fcfc3ba831efa20f286d0ac17cb

The animation bug is fixed issuing a animation stop. If engy is indeed similar to osok/gg getting stuck, the way recon attack was reanimated should fix it.