More general improvements to v2

ArcanePlugins / Treasury

🏦 A powerful multi-platform library for next-level plugin integrations.

Other

56 stars 13 forks source link

Closed lokka30 closed 1 year ago

lokka30 commented 1 year ago

Aims to patch #248

[x] getStartingBalance moved back to Currency - the same method is kept which uses an account context, we were just meant to put it in Currency instead of Account
[x] Make Currency#getDecimal dependent upon a Locale

lokka30 commented 1 year ago

Ready for review -> squash and merge

lokka30 commented 1 year ago

You may wonder why the commit messages look weird: just found out git doesn't like me using inline code blocks in the commit messages.

MrIvanPlays commented 1 year ago

It looks like you don't like the current checkstyle (.editorconfig). Want to switch to google java format?

lokka30 commented 1 year ago

it's not doing a bad job, so I'll keep it as-is unless you want to change it. hit squash and merge whenever you're happy with it 🙂

MrIvanPlays commented 1 year ago

it's not doing a bad job, so I'll keep it as-is unless you want to change it. hit merge whenever you're happy with it slightly_smiling_face

yeah i guess let's just stick with that. also the enormous diff of changing all the classes to gjf