`Currency`: Should we map display names against locales?

ArcanePlugins / Treasury

🏦 A powerful multi-platform library for next-level plugin integrations.

https://hangar.papermc.io/ArcanePlugins/Treasury

Other

56 stars 13 forks source link

`Currency`: Should we map display names against locales? #255

Closed lokka30 closed 1 year ago

lokka30 commented 1 year ago

Currently, display names are not translatable per-locale in Currency, which does not conform with the other translatable features (being the decimal char, formatting, and parsing).

Should the display names (singular and plural) be mapped by locale, just like the decimal char is?

MrIvanPlays commented 1 year ago

sure why not

Jikoo commented 1 year ago

I'm not opposed to it. This being MC, currencies are much more likely to be things like "gold" or "coins" and have translations, unlike many real-world currencies.

MrIvanPlays commented 1 year ago

fixed in https://github.com/ArcanePlugins/Treasury/commit/ed5847d6be5a629ddf8d3ec1afb73cef4996fec7 and https://github.com/ArcanePlugins/Treasury/commit/57e8a3eddffe95b4ac245459d8f1c6f74a991142