search

ArcanePlugins / Treasury

🏦 A powerful multi-platform library for next-level plugin integrations.
https://hangar.papermc.io/ArcanePlugins/Treasury
Other
56 stars 13 forks source link

`Account`: Rename `setPermission`, `hasPermission` to use a plural #257

Closed lokka30 closed 1 year ago

lokka30 commented 1 year ago

In [Account](), I will rename setPermission and hasPermission to setPermissions and hasPermissions respectively. This is because they accept a list of permissions, not just a single permission. Not only does this raise the level of consistency in the API, it's better grammatical practice.

MrIvanPlays commented 1 year ago

making an elephant from a fly...

lokka30 commented 1 year ago

making an elephant from a fly...

so, yes?

MrIvanPlays commented 1 year ago

fixed in https://github.com/ArcanePlugins/Treasury/commit/ed5847d6be5a629ddf8d3ec1afb73cef4996fec7 and https://github.com/ArcanePlugins/Treasury/commit/57e8a3eddffe95b4ac245459d8f1c6f74a991142