search

ArcanePlugins / Treasury

🏦 A powerful multi-platform library for next-level plugin integrations.
https://hangar.papermc.io/ArcanePlugins/Treasury
Other
57 stars 13 forks source link

Last thoughts on Treasury v2's API? YOUR OPINION is wanted! #279

Closed MrIvanPlays closed 1 year ago

MrIvanPlays commented 1 year ago

If you have any comments on the 2.0.0 API and stuff you'd like changed, please state your opinion here.

As for the meantime: image

lokka30 commented 1 year ago

Hi @Jikoo, @MrNemo64, @yannicklamprecht, @creatorfromhell, and @Geolykt, Just tagging you in case you wanted to add any comments as we are about to wrap up all code changes for Treasury v2's API and would prefer to not make any breaking changes for the distant future.

MrNemo64 commented 1 year ago

Hi @Jikoo, @MrNemo64, @yannicklamprecht, @creatorfromhell, and @Geolykt, Just tagging you in case you wanted to add any comments as we are about to wrap up all code changes for Treasury v2's API and would prefer to not make any breaking changes for the distant future.

To be honest, university has been consuming all my time for quite some months now so I'm not up to date with the api, I don't know what changed and such. I've looked arround a bit on dev/2.0.0 and I've seen things like the AccountAccessor which I really like. I don't really know what changed, but I like what I saw. Good job to whoever has been doing all of this

lokka30 commented 1 year ago

Best of luck with your studies, I've been dealing with the same lately (and will be for another ~2 years). Ivan's kindly done a ton of development heavy lifting for us. Thanks for your thoughts!

Jikoo commented 1 year ago

I think I've been moderately good about staying abreast of things and reviewing most PRs, though I haven't done much else. I'm also (back) in the university boat for a career transition, life's been a bit hectic. Big shoutout to Ivan for carrying us to this release!

lokka30 commented 1 year ago

Best of luck to you as well Jikoo :)

yannicklamprecht commented 1 year ago

The only thing I found was that NonPlayer and Plugin with the namespaced key will be equal. Should it be that way? Rest of the API I looked into, is way better than before.

lokka30 commented 1 year ago

The only thing I found was that NonPlayer and Plugin with the namespaced key will be equal. Should it be that way? Rest of the API I looked into, is way better than before.

Awesome to hear, thanks for your feedback! Please could you elaborate on the NamespacedKey part - not quite sure what you mean here?

MrIvanPlays commented 1 year ago

I see. I think we should also do a class check in the equals inside Cause.NonPlayer and Cause.Plugin

yannicklamprecht commented 1 year ago

I see. I think we should also do a class check in the equals inside Cause.NonPlayer and Cause.Plugin

You do but afterwards just checking the key twice. Just remove the second if statement.

lokka30 commented 1 year ago

I've been discussing with Ivan on Discord about replacing the NamespacedKey for Cause.Plugin with just a String