search

Arcaster42 / rhymus

An open-source rhyming game project designed for new developers and first-time contributors.
https://rhymus-one.vercel.app
MIT License
12 stars 15 forks source link

test environment #24

Closed dhuang612 closed 4 years ago

dhuang612 commented 5 years ago

Hi,

I've been reviewing the way that you setup the mocha tests using chai. I've noticed that jsdom is required into the project but we aren't using it to test any of the html dom elements? Is this something that I can setup?

Also from the jsdom-mocha npm page: Deprecation notice: Consider jsdom-global instead, a simpler alternative that also works outside of Mocha. mocha-jsdom still works, but jsdom-global is better supported.

https://www.npmjs.com/package/mocha-jsdom

Arcaster42 commented 5 years ago

Feel free to use any additional packages for testing. Testing is a great thing, and we need to cover our code base.

dhuang612 commented 5 years ago

okay,

I am going to keep working on this testing stuff then, thanks

dhuang612 commented 5 years ago

update

okay, I understand a bit more the tests are supposed to run in the browser.

The tests are still failing however, and I'm reviewing that right now.

Screen Shot 2019-10-31 at 5 30 29 PM
dhuang612 commented 5 years ago

created PR #48

dhuang612 commented 4 years ago

I'll add some additional tests to cover code logic

Arcaster42 commented 4 years ago

Thanks for your ongoing work improving the test code coverage.

dhuang612 commented 4 years ago

created PR #51

dhuang612 commented 4 years ago

created PR #52 tied up some loose ends