search

Arcaster42 / rhymus

An open-source rhyming game project designed for new developers and first-time contributors.
https://rhymus-one.vercel.app
MIT License
12 stars 15 forks source link

Vue conversion from vanilla JS #56

Closed Arcaster42 closed 4 years ago

Arcaster42 commented 4 years ago

The application is feature-complete in vanilla JS, but now there's a new master-vue branch to be done! You can use the existing master branch to model the component development. Unit tests and Vuex are available as needed.

yuriechan commented 4 years ago

Hi,

When you say,

'use the existing master branch to model the component development'

, is the whole purpose to initialize vue-app from scratch?

How is this better than fetching your remote branch master-vue and start creating components on my feature branch?

Arcaster42 commented 4 years ago

The meaning of that phrase is, make the Vue version as close to the master branch as possible. The branch containing Vue is currently just an initialization. There is some configuration done already, so this saves others from having to run the vue create command as well as figure out the basic configuration for things like the vue.config.js devServer and such. If you were to initialize your own Vue project and open a branch, Git would assume the files you initialized are intended to replace all existing files here.

yuriechan commented 4 years ago

Okay, then if I were to do this issue, I will base my feature branch from master-vue to create the components since you've initialized Vue and structured the folders already. I understand that I should be referring to the master branch for logic and UI. (At first, I misunderstood that we had to base our branch to master, instead of master-vue)

yuriechan commented 4 years ago

Also, should I open a PR per component? or should I open a PR once everything is converted into Vue?

Arcaster42 commented 4 years ago

PRs should be done by feature. If a feature is large, implement a minimally viable iteration of it with a basic implementation of it.

yuriechan commented 4 years ago

I'm thinking of continuing to make commits to this issue to introduce Vuex to this application. Or, should I create a new issue specifically for adding Vuex?

Arcaster42 commented 4 years ago

I'm going to make another branch specifically for a Vuex integration.

Arcaster42 commented 4 years ago

You can now work from master-vue-vuex for the Vuex implementation. I'm going to close this issue now.