search

Arcaster42 / rhymus

An open-source rhyming game project designed for new developers and first-time contributors.
https://rhymus-one.vercel.app
MIT License
12 stars 15 forks source link

Vue conversion from vanilla js #57

Closed yuriechan closed 4 years ago

yuriechan commented 4 years ago

This resolves... #56

Any feedback regarding my Vue code is very much appreciated. (Vuex is not used in this PR)

For example...

  1. The separation of application into components. --> I created a total of three custom components and many props were handled in this application which may look a bit messy.

  2. The usage of object option inside Vue instance (data(), computed(), watch()... etc)

  3. Naming conventions for props. --> All the props have the same name as the original data passed from its parent component. I was not sure if this is a good practice in terms of readability.

Is there anything different from the original master?

Not much. The view (HTML + CSS) is all copied and pasted from the original master. The business logic(JS) is 95% copied and pasted from the original master. The only distinctive difference aside from the implementation of the framework is, restartGame function was removed because this logic is handled inside startGame function.

After PR is accepted...

I would like to introduce Vuex and manage data using store.

Arcaster42 commented 4 years ago

In case there are any last-minute changes you want to make, I'll leave this PR open for another day. After that, I'll merge it.