ArcetriAdaptiveOptics / arte

Arcetri Random sTuff collEction
MIT License
2 stars 0 forks source link

new class implemented: surface fitting #24

Open imapeartree opened 3 years ago

imapeartree commented 3 years ago

surface fitting: get a masked array, get coefficients of Zernike or polynomial expansions

lbusoni commented 3 years ago

I think most/all the functionality of SurfaceFitter are already in ModalDecomposer. I'll add the documentation to ModalDecomposer and we'll check if it overlaps SurfaceFitter and where to extend it

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 80.48% and project coverage change: -10.16 :warning:

Comparison is base (9372669) 74.53% compared to head (02e6585) 64.38%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #24 +/- ## =========================================== - Coverage 74.53% 64.38% -10.16% =========================================== Files 131 138 +7 Lines 8231 9875 +1644 =========================================== + Hits 6135 6358 +223 - Misses 2096 3517 +1421 ``` | [Impacted Files](https://app.codecov.io/gh/ArcetriAdaptiveOptics/arte/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ArcetriAdaptiveOptics) | Coverage Δ | | |---|---|---| | [arte/types/scalar\_bidimensional\_function.py](https://app.codecov.io/gh/ArcetriAdaptiveOptics/arte/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ArcetriAdaptiveOptics#diff-YXJ0ZS90eXBlcy9zY2FsYXJfYmlkaW1lbnNpb25hbF9mdW5jdGlvbi5weQ==) | `80.00% <40.00%> (ø)` | | | [arte/utils/shape\_fitter.py](https://app.codecov.io/gh/ArcetriAdaptiveOptics/arte/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ArcetriAdaptiveOptics#diff-YXJ0ZS91dGlscy9zaGFwZV9maXR0ZXIucHk=) | `78.30% <66.66%> (-0.55%)` | :arrow_down: | | [arte/utils/surface\_fitter.py](https://app.codecov.io/gh/ArcetriAdaptiveOptics/arte/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ArcetriAdaptiveOptics#diff-YXJ0ZS91dGlscy9zdXJmYWNlX2ZpdHRlci5weQ==) | `73.78% <73.78%> (ø)` | | | [test/utils/surface\_fitter\_test.py](https://app.codecov.io/gh/ArcetriAdaptiveOptics/arte/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ArcetriAdaptiveOptics#diff-dGVzdC91dGlscy9zdXJmYWNlX2ZpdHRlcl90ZXN0LnB5) | `98.11% <98.11%> (ø)` | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/ArcetriAdaptiveOptics/arte/pull/24/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ArcetriAdaptiveOptics)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.