ArchGPT / insomnium

Insomnium is a fast local API testing tool that is privacy-focused and 100% local. For testing GraphQL, REST, WebSockets and gRPC. This is a fork of Kong/insomnia
MIT License
3.33k stars 125 forks source link

Fix prompt being shown twice (#96) #102

Closed thenoseman closed 8 months ago

thenoseman commented 8 months ago

Reason (as I can see it): The interpolation of the request params is done twice. Both interpolations were called using the context RENDER_PURPOSE_RENDER which triggers the prompt in local-template-tags.ts. This file contains the "prompt" function as a plugin. context.app.prompt is called there without checking for the already set cached value when context === "send".

This "fix" renders the first time with renderPurpose set to "no-render" so no prompt is called in this case since no plugins (the "prompt") are called anyway.

This might have side effects I have not encountered so far!

Closes #96

ps. A version for mac (universal) that incorporates this fix is here: https://github.com/thenoseman/insomnium/releases/tag/fix-double-prompt-test-release

This is just for testing purposes and should not be used longterm!

archywillhe commented 8 months ago

thanks! sounds good