ArchGPT / insomnium

Insomnium is a fast local API testing tool that is privacy-focused and 100% local. For testing GraphQL, REST, WebSockets and gRPC. This is a fork of Kong/insomnia
MIT License
3.36k stars 139 forks source link

No icon on linux in taskbar #38

Closed lazystone closed 10 months ago

lazystone commented 10 months ago

Expected Behavior

Some icon would be nice to have.

Actual Behavior

image

Reproduction Steps

  1. Install 0.2.1-b

Is there an existing issue for this?

Additional Information

No response

Insomnium Version

0.2.1-b

What operating system are you using?

Ubuntu

Operating System Version

KDE Neon 5.2.7

Installation method

deb

Last Known Working Insomnium version

0.1.3

lazystone commented 10 months ago

Actually, now I think that application icons didn't work correctly even in 0.1.3

In 0.1.3 I see default InsomniA icon, which I guess packed in Electron, but icon in the deb package is different.

lazystone commented 10 months ago

Ok, I think it's related to https://github.com/electron-userland/electron-builder/issues/5294

Inside the deb package icon is indeed in the 0x0 folder.

So I guess solution would be to provide pre-scaled icons, according to https://www.electron.build/icons.html#linux

archywillhe commented 10 months ago

Ok, I think it's related to https://github.com/electron-userland/electron-builder/issues/5294

aw thanks! good find; I will resolve this in the next release

lazystone commented 10 months ago

@archywillhe it's almost fixed, one more line is needed: icon: 'src/icons'

In electron-builder.config.js:

  linux: {
    artifactName: `${BINARY_PREFIX}-\${version}.\${ext}`,
    executableName: 'insomnia',
    icon: 'src/icons',

Tried it locally - can see icon in the taskbar now:

image

archywillhe commented 10 months ago

thanks! meriging your pr now :)