Archie3d / qpdf

PDF viewer widget for Qt
GNU Lesser General Public License v2.1
170 stars 58 forks source link

licensing issue #12

Closed rahmanshaber closed 6 years ago

rahmanshaber commented 6 years ago

the problem is i will include this corepdf in my app CoreBox. for this i need one qmake for my main app that could include all the cpp and header file including corepad's library.

so my consernt is that if i include the library in the same qmake , is there any problem?? like this ` TEMPLATE = app

CONFIG += c++11

QT += widgets\ webengine\ webenginecore\ webenginewidgets\ webchannel

HEADERS += corepdf.h\ qpdflib/pdfjsbridge.h \ qpdflib/qpdf.h \ qpdflib/qpdfwidget.h \

SOURCES += \ corepdf.cpp \ main.cpp \ qpdflib/pdfjsbridge.cpp \ qpdflib/qpdfwidget.cpp \

RESOURCES += \ qpdflib/pdfview.qrc `

rahmanshaber commented 6 years ago

hello . sorry to bother you again . my app release in on hold for this. my concern about licensing of the library. i asked it in qt forum .they said , it's ok. but i need your statement.

i have no choice with out your library. i said the user that i will include a pdf viewer. if you say no , i have to release my app without it.and that will be a big issue for me.

i hope you understood the issue. thanks for all the help.

Archie3d commented 6 years ago

Hi, It’s ok, no problem. But if you don’t want your project to become lgpl you should have compiled qpdf into a library, and then link it dynamically distributing the dll, like you do with Qt.

On 19 May 2018, at 04:51, rahmanshaber notifications@github.com wrote:

hello . sorry to bother you again . my app release in on hold for this. my concern about licensing of the library. i asked it in qt forum .they said , it's ok. but i need your statement.

i have no choice with out your library. i said the user that i will include a pdf viewer. if you say no , i have to release my app without it.and that will be a big issue for me.

i hope you understood the issue. thanks for all the help.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

rahmanshaber commented 6 years ago

thank you very much. i tried to do compiled library and then link it dynamically . but problem is , if app compiled in different architecture.

is my whole app will be a lgpl or not??

Archie3d commented 6 years ago

There should be no problem building it for different architecture (if the viewer example, which links qpdf dynamically, works for your target architecture - yours should work as well). If you link statically, then you have to be lgpl (the same as with Qt, which is also lgpl). If you link dynamically (dll, so, dylib), then you can license your application as you wish.

On 19 May 2018, at 07:57, rahmanshaber notifications@github.com wrote:

thank you very much. i tried to do compiled library and then link it dynamically . but problem is , if app compiled in different architecture.

is my whole app will be a lgpl or not??

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

rahmanshaber commented 6 years ago

ok. understood