search

ArchipelagoMW-HollowKnight / HollowKnight.ArchipelagoMapMod

Archipelago Randomizer Map is a Hollow Knight mod used with the Archipelago MultiWorld Randomizer. It helps to find both item and transition checks.
GNU General Public License v3.0
1 stars 2 forks source link

Soul Totem Map Icons do not Function Properly #1

Open Fatman922 opened 2 years ago

Fatman922 commented 2 years ago

Intended Behaviour When soul totems are randomized, and one of your own soul totems is hit to collect it, the icon for the location should change from showing the item that is there in vanilla, to a soul totem. Also, the location should be shown as persistent (with a hexagon shape).

Actual Behaviour The icon for the location does not change in any way, as if the location was never collected.

I cannot recall confidently whether or not this also applies for soul refills for another player's world, but I believe it does.

Levisaxos commented 2 years ago

This same problem occurs with lifeblood cocoons. The icon will stay the same, asif not collected.

Would request for this to chancged to either having it change to the icon to be green and into the items that it is (e.a. soul totem, or lifeblood cocoon). Or have the option to remove them from the map entirely.

When an item has been collected (once) it should be removed or shown that you have seen/collected it.

thislooksfun commented 1 year ago

I can confirm that soul totems from other players' games also have this bug. I have several soul refill locations in one of my worlds (one soul totem of my own, two soul totems from other players, and one of my own soul refills with no physical totem that I can't even pick up again for some reason) that all persist on the map even after I've collected them multiple times.

I don't know if this is a bug in this map mod, or if it's a bug in the way Archipelago reports the item states, but it's really annoying.

I like @Levisaxos' idea of shifting it from the "randomized" category to the "others" category after collection so those who want to find it again can do so, but those who are just looking for unchecked locations can disable it.

Levisaxos commented 1 year ago

I'm unaware how this goes, how to submit a bugfix or anything. Maybe i'll go look for some info in the archipelago discord.

Anyways, I downloaded the project and as i'm a c# programmer myself, i managed to create a "fix" for this. Since mostly the shuffleing and collecting of items is handled by a third party mod called "ItemChanger", there's no "normal" way to fix this bug. What I did in my local version is add specifically these locations to a list in the local settings. When the location is checked, it will put that locations name in the local settings and whenever it loads the map it will check also for items in the local settings to see if they have been checked before. This make it so that both soul totems and lifeblood cocoons are now shown as what they are with a green outline.

For now I only have this on local but i'll go try and find out how to get this committed and approved. Since there currently is no official hollowknight developer (Ijwu stepped down) it might take some time and be difficult.

If anyone can help, feel free to contact me on discord!

thislooksfun commented 1 year ago

If you're confident you fixed the issue, why don't you just submit a pull request to this repository?

thislooksfun commented 1 year ago

@Levisaxos Turns out there's a cleaner way to do this. I put up a PR (#3) with the fix.