search

ArchitectSMP / mc-config

Minecraft server plugin configurations for the ArchitectSMP community
1 stars 0 forks source link

PremiumVanish doesn't work as intended #46

Open FlooferDoofer opened 3 years ago

FlooferDoofer commented 3 years ago

Players can see us login, logout and in the tablist. In the tablist our names do not get greyed out or italic even for others. Aphelia bot (in-game-chat) tells players in Discord when we login or logout in Vanish

bloodycoffin commented 3 years ago

@ChipWolf next to the globalchat the PremiumVanish is also no longer working as expected. Originally noticed by admins 4 days ago. I amended the comment to reflect all current problems

bloodycoffin commented 3 years ago

Player ShadowKiller reported being able to see the admins even though he has no additional LuckPerms rights to be able to do so

ChipWolf commented 3 years ago

ArchitectSMP/k8s-gitops#92 will solve the final point regarding join/leave showing in Discord It looks like, the TAB plugin supports PremiumVanish, so we'll have to investigate config there. Do we see join/leave network/game messages also @FlooferDoofer?

ChipWolf commented 3 years ago

I've figured out what the issue is with the tab-list.

We use the "spy servers" feature of TAB to ensure players can see all players on the network from each of the servers. However, this line of code will return true to the shouldSee-the-tab-list-assertion if the user is in a "spy server" before checking if the user is permitted to see vanished users.

I've raised an issue (https://github.com/NEZNAMY/TAB/issues/278) with @neznamy to fix

ChipWolf commented 3 years ago

The TAB developer has resolved this in v2.8.11-pre5, seems like it works in dev. The jar is replaced on the main proxy & now it just requires a restart.

ChipWolf commented 3 years ago

Two smaller issues, the leave message PremiumVanish fires when a user vanishes is 'left the game' rather than 'left the network'. I've fixed this in the messages config, the servers will need a restart.

As per MultiChat/Development#167, there isn't a feature to disable quit messages while in vanish for MultiChat so that'll just need to be implemented. A temporary workaround is disabling the leave message on vanishing and then leaving/rejoining to be completely incognito until it's implemented.

ChipWolf commented 3 years ago

I implemented a feature to silence quit messages when vanished for MultiChat https://github.com/MultiChat/Development/pull/168 Will replace our jar when @OllieMartin puts out an official release

bloodycoffin commented 3 years ago

Have replaced Aphelia with Discord SRV and removed join/quit messages completely from the data that Discord SRV sends to Discord from Minecraft. Did another test with players without additional rights and they can no longer see us join/leave while in Vanish, don't get a separate left the network message when leaving in Vanish and no longer visible in tab menu when Vanished. As we have reached the desired effect I will close the issue.

ChipWolf commented 3 years ago

Not sure why this was closed. silence quit messages is not yet implemented as per https://github.com/ArchitectSMP/k8s-gitops/issues/76#issuecomment-786880707

bloodycoffin commented 3 years ago

Chip's suggestion as MultiChat appears abandoned is to switch to BungeeChat, so far this looks like a good replacement and if this fixes the PremiumVanish plugin I don't think this is a bad idea https://www.spigotmc.org/resources/bungee-chat.12592/