search

ArchitectSMP / mc-config

Minecraft server plugin configurations for the ArchitectSMP community
1 stars 0 forks source link

Shopkeepers can no longer be renamed #57

Closed bloodycoffin closed 3 years ago

bloodycoffin commented 3 years ago

SilverVee attempted to rename the shopkeeper, it didn't work. FlooferDoofer (OP) went over to attempt it and it also didn't work.

Must have something to do with a change we've done recently. There are no changes done to the Shopkeepers config to cause this so it has to be another plugin or other config that is causing a conflict.

ChipWolf commented 3 years ago

I recall not being able to rename a shopkeeper some time ago, @blablubbabc might have some advice here. On the shopkeeper topic, there's also Shopkeepers/Shopkeepers#722 which requires a config change to prevent spawning baby villagers.

blablubbabc commented 3 years ago

The only issue I am aware of related to shopkeeper renaming are BungeeCord chat (muting) plugins. So if you guys use BungeeCord, or any other kind of server proxy, check if you are using a proxy-level plugin or feature that might prevent chat packets from passing through to the underlying Spigot server. Edit: For instance, if you use a chat plugin on the proxy-level that implements some kind of network-wide chat by cancelling the chat packet and manually sending messages, that will probably be problemantic as well.

ChipWolf commented 3 years ago

The only issue I am aware of related to shopkeeper renaming are BungeeCoord chat (muting) plugins. So if you guys use BungeeCoord, or any other kind of server proxy, check if you are using a proxy-level plugin or feature that might prevent chat packets from passing through to the underlying Spigot server. Edit: For instance, if you use a chat plugin on the proxy-level that implements some kind of network-wide chat by cancelling the chat packet and manually sending messages, that will probably be problemantic as well.

Yes, that's exactly what we're doing, it'll be gChat for BungeeCord handling chat at the proxy-level. We'll have to investigate a new chat solution in that case or implement a compatibility hook. Thanks for the help @blablubbabc!

blablubbabc commented 3 years ago

Maybe this might be a solution: https://github.com/blablubbabc/BungeeForwardCancelledChat

ChipWolf commented 3 years ago

It works 😄 Thank you for developing that plugin so quickly, we're beyond grateful @blablubbabc