andrewlalis
commented
2 years ago I originally made the selection viewer as a separate view because that was the easiest thing to do, and I just needed to add that functionality quickly so that Mohamed could use it to assess selections of emails. In retrospect it's sort of a one-off solution to a specific use case.
As for adding it to the main browse panel, I've also considered how I might do that, and I think the way in which I would, would be to make a simple dialog where users could enter the list of email ids, and use the IdInFilter as just another way that users can filter the emails.
That being said... the whole user interface is quite bloated already; at least the browse panel and search panel, and could use some refactoring, but at the moment I'm very busy with finishing up my actual thesis paper and presentation and all the formalities of that.
I've been using the email selection viewer recently, and was wondering whether there's a reason it's a separate dialog, rather than just another tab in the main browse panel?
if there isn't a reason, I was planning to add it into the main browse panel anyways, as I find the current workflow quite disruptive (lots of unnecessary alt-tabbing, closing the wrong windows, etc.). Do you have any suggestions on how I'd approach this? I think the amount of overlapping code between the lucenesearchpanel, the simplebrowsepanel, and now the viewer might increase because of this as well, so there'd probably be use of an additional abstraction layer.
Keeping them as separate windows currently also introduces the bug that if you close the main page, they others don't close and become completely unusable.