search

ArchitecturalKnowledgeAnalysis / EmailIndexer

Utility for generating Lucene indexes for collections of emails.
MIT License
1 stars 2 forks source link

Bug: EmailRepository.loadRepliesRecursive loads too many emails. #3

Closed wmeijer221 closed 2 years ago

wmeijer221 commented 2 years ago

I've been working on an export method to PDF for lucene search results in the EmailBrowser. Since there was an implementation for plain-text already, I followed that as a template. In the plain text version, EmailRepository.loadRepliesRecursive is used to load a complete mailing thread. However, I believe that the current implementation loads the same emails multiple times, resulting in gigantic exports for long mailing threads.

andrewlalis commented 2 years ago

Do you mean that for a given email, it might contain duplicate replies?

wmeijer221 commented 2 years ago

yes

andrewlalis commented 2 years ago

I'm working on refactoring the structure of the dataset to include tags as separate entities, along with some other fixes. I plan to address this there.

andrewlalis commented 2 years ago

I'm closing this now that I have actually completely removed this method from the EmailRepository in the latest version.