ArchiveLabs / iiif.archivelab.org

Internet Archive IIIF Image 2.0 Server
GNU General Public License v3.0
30 stars 13 forks source link

Add collections #111

Closed glenrobson closed 1 year ago

glenrobson commented 1 year ago

Trying with renamed branch with out _ in the name...

glenrobson commented 1 year ago

Example collection: https://gist.github.com/glenrobson/f93330bac2efc7e4103caa7dc8e61c92

This fixes:

benwbrum commented 1 year ago

This looks good; description, ordering, and types are all great.

The only thing I'd add to the wish-list for future work would be to multi-lingualize the "Page 3 of 8" label. Since we're generating that text, we know it's English so don't need to use none for the language, plus we can add translations to other languages.

hadro commented 1 year ago

Maybe worth adding a new issue for wishlist items like that, given that we’re quickly approaching the basics for 1.0 release?

On Fri, Jun 2, 2023 at 12:07 Ben W. Brumfield @.***> wrote:

This looks good; description, ordering, and types are all great.

The only thing I'd add to the wish-list for future work would be to multi-lingualize the "Page 3 of 8" label. Since we're generating that text, we know it's English so don't need to use none for the language, plus we can add translations to other languages.

— Reply to this email directly, view it on GitHub https://github.com/ArchiveLabs/iiif.archivelab.org/pull/111#issuecomment-1573975276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAT4RSRX73OMXBR6C5IVGTXJIFTVANCNFSM6AAAAAAYXS6X5M . You are receiving this because you are subscribed to this thread.Message ID: @.***>

glenrobson commented 1 year ago

For the short term I've set the label of the next collection as English:

{
      "id": "http://localhost:8080/iiif/3/frankbford/2/collection.json",
      "label": {
        "en": [
          "Page 2 of 8"
        ]
      },
      "type": "Collection"
}