ArchiveTeam / ArchiveBot

ArchiveBot, an IRC bot for archiving websites
http://www.archiveteam.org/index.php?title=ArchiveBot
MIT License
356 stars 72 forks source link

Preflight test does not have the same environment variables as wpull inside the pipeline #492

Open JustAnotherArchivist opened 3 years ago

JustAnotherArchivist commented 3 years ago

Cf. #490 and #491

Environment variables on the preflight test are not modified, but inside the pipeline, only the selected ones specified in wpull_env in pipeline.py are passed to wpull. This means that the preflight test might succeed but the real wpull process might hang, as in that scenario of a small separate /tmp partition with TMPDIR set to something else to keep wpull from putting anything there or monitoring its disk space.