search

ArchiveTeam / grab-site

The archivist's web crawler: WARC output, dashboard for all crawls, dynamic ignore patterns
Other
1.31k stars 129 forks source link

Make it work again in Python 3.10 #215

Open iacore opened 2 years ago

TheTechRobo commented 2 years ago

This PR's Pipfile makes the minimum version Python 3.10; this will break it for many users.

Also, the fixes for ludios_wpull should be merged into ludios_wpull officially before this is.

iacore commented 2 years ago

Most users probably don't use Pipfile for installing the package. Also, I don't know which minimum version will work.

Also, what's the deal with ludios_wpull and https://github.com/ArchiveTeam/wpull?

TheTechRobo commented 2 years ago

ludios_wpull is @ivan 's fork of wpull when it appeared that wpull wasn't maintained (still isn't); he made a bunch of breaking changes.

ludios works with more versions of python (although still not the latest)

ivan commented 2 years ago

I believe this PR does not make grab-site work with Python 3.10 because we still have incompatibilities preventing an upgrade to Python 3.9 (https://github.com/ArchiveTeam/ludios_wpull/issues/20)

ivan commented 2 years ago

oh, I see you made changes to wpull in your fork. I guess I would need Python 3.10 support to be upstream in ArchiveTeam/ludios_wpull (or ArchiveTeam/wpull if the useful ludios_wpull changes are incorporated.)