search

ArchiveTeam / grab-site

The archivist's web crawler: WARC output, dashboard for all crawls, dynamic ignore patterns
Other
1.31k stars 129 forks source link

Update macOS install script to reflect Python 3.8.x (rather than 3.7) #216

Closed LeeBinder closed 2 years ago

LeeBinder commented 2 years ago 
brew update
brew install python@3.9 libxslt re2 pkg-config
/usr/local/opt/python@3.9/bin/python3 -m venv ~/gs-venv
PKG_CONFIG_PATH="/usr/local/opt/libxml2/lib/pkgconfig" ~/gs-venv/bin/pip install --no-binary lxml --upgrade git+https://github.com/ArchiveTeam/grab-site

👍

TheTechRobo commented 2 years ago

grab-site does not work in Python 3.9: https://github.com/ArchiveTeam/ludios_wpull/issues/20

LeeBinder commented 2 years ago

Hi @TheTechRobo - that's helpful to know. You have admin access here, don't you. How about if you add this info to the https://github.com/ArchiveTeam/grab-site#install-on-macos section? To add clarity that python 3.7 is actually required 👍.

ivan commented 2 years ago

Thanks, I have updated it to use python@3.8.

I considered adding a disclaimer just now, but people incorrectly mutate the install steps in many different ways and I don't really want to cover every possible thing in the README.

TheTechRobo commented 2 years ago

@LeeBinder I don't have admin access here.

LeeBinder commented 2 years ago

Fine - Ivan already updated the manual, and grab-site is working here now :)