search

ArchiveTeam / grab-site

The archivist's web crawler: WARC output, dashboard for all crawls, dynamic ignore patterns
Other
1.35k stars 134 forks source link

Simplify development setups #69

Closed DanielOaks closed 8 years ago

DanielOaks commented 8 years ago

These are just a few small changes to cater to dev environments, and make things a bit easier for those using virtualenvs and running into issues.

The changes to use env python3 instead of just python3 are because doing it the env way makes sure the right Python binary is selected when using virtualenvs (which are very useful for development environments), as well as just being the recommended way to launch shell scripts. This makes sure the right python3 binary currently in the path is selected, rather than always the one living at /usr/bin/python3.

The .gitignore changes extend it to ignore OS-specific files, Windows/OSX/Linux, as well as more Python files. This includes the specific directories used for virtualenvs and other Python stuff that should be ignored by git.

I use gitignore.io to generate most of my gitignore files, so I do like leaving their little tagline up the top. But I can just as easily get rid of it, just let me know.

ivan commented 8 years ago

The env change looks good, thanks.

I strongly prefer not to have .gitignore list every possible thing that might need to be ignored, though. If you found that some things need to be ignored in your development environment, can you add just those things? No inline comments needed, either.

ivan commented 8 years ago

I have committed the env python3 change. If you need particular changes to .gitignore for your development environment, please submit a new PR.