ArchiveTeam / seesaw-kit

Making a reusable toolkit for writing seesaw scripts
Other
69 stars 30 forks source link

BREAKING: Drop Python 2.7 and 3.0-3.6 support, unbreak 3.10 #128

Closed Rexogamer closed 1 month ago

Rexogamer commented 2 years ago

Should fix #127, although the CI situation still needs sorting out (possibly switch to GH Actions?)

Tested - works on 3.8

JustAnotherArchivist commented 2 years ago

Thanks for working on this. I applaud anyone that stabs another knife in Python 2's back. It deserves it at this point. :-)

Haven't reviewed closely, but just some thoughts at a glance.

I think we should keep run-pipeline3 and run-warrior3 for compatibility. Lots of instructions and automation use them, for example all the (recent) *-grab repos and the Docker images. But I think both those and the non-3 versions should use entry_points rather than this 'scripts in the repo root' mess, which had some value with Python 2 compatibility (although not really) but is useless now.

I'd love to see seesaw.six go entirely. I hate vendored dependencies in general, but it's also unnecessary with Python 3. That's a larger refactoring though...

I'll look into CI migration.

MPM1107 commented 2 years ago

I haven't tested to confirm, but I think the version of Tornado currently required by seesaw doesn't support python 3.10 either, so that could potentially need some work as well. Could someone double check that?

JustAnotherArchivist commented 2 years ago

Yeah, seesaw requires Tornado 4.x currently, which doesn't even officially support Python 3.7, so that wouldn't surprise me at all.

Rexogamer commented 2 years ago

I'd be willing to upgrade Tornado, but this would also break support for 3.4 and 3.5 (although considering the fact that even 3.6 is EOL this probably isn't that big of a deal, except for any remaining XP users which I highly doubt would still be able to use the Warrior)

Rexogamer commented 2 years ago

Testing locally, the Warrior loads and a task seems to be queued but there doesn't appear to be any progress? Not entirely sure what's going on

JustAnotherArchivist commented 2 years ago

Are you testing against prod?

Rexogamer commented 2 years ago

I was running the pipeline - I slightly suspect this is related to some of the code removed due to the Torando update, but hmm

JustAnotherArchivist commented 2 years ago

Please do not run any modified code against the live system.

Rexogamer commented 2 years ago

I was running the test pipeline - I was under the assumption this was test only and didn't send any data to the prod server, as it seemingly takes a localhost URL

JustAnotherArchivist commented 2 years ago

The ones in https://github.com/ArchiveTeam/seesaw-kit/tree/development/tests? Yeah, I think those are fine I think.

Rexogamer commented 2 years ago

It was the one listed in the README - so I think it's the test pipeline, yes

TheTechRobo commented 1 year ago

Is this compatible with existing seesaw scripts?

Rexogamer commented 1 year ago

Is this compatible with existing seesaw scripts?

In terms of the entry points, yes - however, if any of them use Python < 3.5 they may need to be upgraded/modified

Rexogamer commented 6 months ago

Not sure if I have the bandwidth/ability to continue working on this, but I think it'd be best to split this PR in two (drop 2/cleanup, then see about fixing 3.10+)

Rexogamer commented 1 month ago

closing per above, apologies