ArchiveTeam / seesaw-kit

Making a reusable toolkit for writing seesaw scripts
Other
69 stars 30 forks source link

Off-by-one error in ExternalProcess max_tries #29

Closed chfoo closed 10 years ago

chfoo commented 11 years ago

ExternalProcess has an OBOE causing max_tries to behave like max_tries - 1. So, if 2 is passed, it only executes at most once and exits.

I think on externalprocess.py Line 77

item["tries"] = 1

should be initialized to 0 instead since it hasn't "tried" the process yet.