search

ArchiveTeam / seesaw-kit

Making a reusable toolkit for writing seesaw scripts
Other
69 stars 30 forks source link

Projects don't update correctly to the latest code #76

Closed chfoo closed 9 years ago

chfoo commented 9 years ago

It appears that it is able to check whether a project needs to be updated, but it doesn't grab the latest code but only an older commit.

I suspect this problem has existed for a while since there were reports of people seeing the "out of date" message in the warrior for a long time.

chfoo commented 9 years ago

I suspect the start_selected_project coroutine isn't scheduled and run in warrior.py. An explicit yield is required. The old engine decorator should be replaced with coroutine too.

chfoo commented 9 years ago

In urlteam2 project, it seems like FETCH_HEAD is pointing to develop and not the master branch. This is wrong because develop, at time of writing, is diverged (not up to date) from master.

Edit: Also wrong because it's the wrong branch in general.