ArchiveTeam / seesaw-kit

Making a reusable toolkit for writing seesaw scripts
Other
69 stars 30 forks source link

Add auto update for runners and warriors #85

Closed 12As closed 9 years ago

12As commented 9 years ago

This pull request adds the ability to trigger automatic updates for runners and warriors using the preexisting out-of-date signal in the tracker. Note that runners have to use the shell script and warriors cannot be updated if they use docker.

chfoo commented 9 years ago

I'm not sure if this is a good idea. A Task shouldn't be in control of the entire warrior.

Is the wrapper script needed? There's already update code inside run_pipeline. It avoids DDoSing GitHub in case of failure.

I think if we want instant auto updating, Seesaw will need to be rewritten with a better architecture.

12As commented 9 years ago

To be honest, I couldn't quite figure out how to trigger those updates and figured it would be safer to have seesaw stop and get restarted by the script regardless.

To your other point, no matter how many concurrent items you run, each pipeline only attempts to update once in the script if the bash && convention is followed in the script

12As commented 9 years ago

I've given this more thought and there may be a different way to do this without a wrapper script and giving control over the pipeline to the script and a minimal rewrite of seesaw architecture. Also, I think chances are minimal of this request getting pulled. Therefore, I'm closing this pull request.