search

ArchivesNationalesFR / rico-converter

A tool to convert EAC-CPF and EAD 2002 XML files to RDF datasets conforming to Records in Contexts Ontology (RiC-O)
https://archivesnationalesfr.github.io/rico-converter/
Other
29 stars 2 forks source link

Rename AgentSubordinationRelation to AgentControlRelation (?) #22

Closed tfrancart closed 1 year ago

tfrancart commented 1 year ago

I can't find AgentSubordinationRelation in latest RiC-O.

rico-converter uses it : https://github.com/ArchivesNationalesFR/rico-converter/blob/master/ricoconverter/ricoconverter-convert/src/main/resources/xslt_eac/eac2rico-relations.xslt#L101

Is it to be replaced with AgentControlRelation ? or deleted ?

florenceclavaud commented 1 year ago

I have checked this. The AgentSubordinationRelation class (and its properties) was removed from RiC-O in December 2020 and is no more present in RiC-O 0.2 (see https://github.com/ICA-EGAD/RiC-O/pull/22). This was a simple deletion, I mean that no new class was created or modified for replacing it. So now in RiC-O 0.2 we just have AgentHierarchicalRelation, superclass of AgentControlRelation, superclass of AgentHierarchicalRelation. AgentSubordinationRelation was a subclass of AgentControlRelation, whose definition did not change. So IMHO, at first look, it should be replaced by AgentControlRelation in the output of RiC-O Converter.

tfrancart commented 1 year ago

This means that the keywords "isSuperiorOf" and "isInferiorOf" that are tested in @xlink:arcrole will be remapped to AgentControlRelation

tfrancart commented 1 year ago

This is an issue as the "isSuperiorOf" and "isInferiorOf" keywords were looked for in the associative relations, while the AgentControlRelation is generated for hierarchical relations. For the moment I completely remove it, to be discussed.

florenceclavaud commented 1 year ago

See my comment to the pull request #29