Archkitten / m22p4-ninjas

0 stars 0 forks source link

Reinhardt Individual review #117

Open Reinhardtlotter opened 2 years ago

Reinhardtlotter commented 2 years ago

Score: 9.3/10 Individual/Pair Evaluation on Create Task Project - 5pts

@app.route('/sunormoon/', methods=['GET', 'POST']) def sunormoon(): pun = ["Youre so sunny", "like father, like sun" ] msg = "FINISH THE TEST FIRST" ques = [] for i in range(7): ques.append("")

ques[6] = None

resultpy = 0
percentagemoon = 0
if request.form:
    for i in range(7):
        reqformval = "ques" + str(i+1)
        ques[i] = request.form.get(reqformval)
        print(ques[i])

ques1 = request.form.get("ques1")

ques2 = request.form.get("ques2")

ques3 = request.form.get("ques3")

ques4 = request.form.get("ques4")

ques5 = request.form.get("ques5")

ques6 = request.form.get("ques6")

ques7 = request.form.get("ques7")

resultpy = calculate(ques1, ques2, ques3, ques4, ques5, ques6, ques7)

    if ques[0] != "":
        resultpy = calculate(ques)
        percentagemoon = 100 - resultpy
    else:
        resultpy = 9999
    if resultpy > percentagemoon:
        msg = (random.choice(pun))

return render_template("sunormoon.html", result=resultpy, moonp=percentagemoon, mesg=msg)

- [ ] Written responses to all the prompts in the performance task https://github.com/Archkitten/m22p4-ninjas/wiki/Reinhardt---Derrick-Create-task

- [ ] 1min video that meets CB create task requirements https://youtu.be/QqZtllgqJjk

Team Final Grading Considerations - 5 pts

- [ ] PBL Github pages. Jekyll, WIKI, live review focus http://compapter.me/ 

PBL theme consistent through project and described in Github Pages https://github.com/Archkitten/m22p4-ninjas/tree/main/templates 
Sassy / Bootstrap https://github.com/Archkitten/m22p4-ninjas/blob/main/templates/layouts/base.html
Blueprint illustration/demonstration

from random import random

from flask import render_template, request

from init import app from crud.app_crud import app_crud from games.games import app_games

from createtask.astronomertrivia import app_astronomertrivia from homepages.homepages import app_homepages

app.register_blueprint(app_crud) app.register_blueprint(app_homepages) app.register_blueprint(app_games)

app.register_blueprint(app_astronomertrivia) import random


CRUD Async Operation - runtime and understanding of JavaScript and Fetch https://github.com/Archkitten/m22p4-ninjas/tree/main/crud
Individual PBL MVC feature/commits showing algorithms written in JS/Python https://github.com/Archkitten/m22p4-ninjas/commit/3d5d0ba49bda70efa66f1b51ab878639bf321229

- [ ] Runtime Features shown in 1 min video https://youtu.be/8vetChs_fH0

Highlight of best features
CRUD/Search on project database tables, easy to identify from UI https://github.com/Archkitten/m22p4-ninjas/tree/main/crud
MVC - a code overview showing usage of MVC (HTML, Routes/Render Template functions, Model functions) https://github.com/Archkitten/m22p4-ninjas/blob/main/main.py 
Google Search or Google translate implemented 
Scrum Board - Overview of completed tasks and Github tangibles https://github.com/Archkitten/m22p4-ninjas/projects/1
AlexD017 commented 2 years ago

9.3/10 pt Good idea of the website All CSS matches with the theme of space Create Task PBL feature was interesting, but seems to need more CSS Both individual and team video well showed the features Doesn't have Google Translate/Search feature

Individual/Pair Evaluation on Create Task Project - 5pts

Team Final Grading Considerations - 5 pts