Possible non-unique caching keys for many requests

Archomeda / Gw2Sharp

A cross-platform .NET wrapper library for the Guild Wars 2 API written in C#

https://archomeda.github.io/Gw2Sharp

MIT License

37 stars 8 forks source link

Possible non-unique caching keys for many requests #119

Closed Archomeda closed 2 years ago

Archomeda commented 2 years ago

It's possible that the many requests do not have their ids transformed to proper cache id keys. It seems to be missing the call to the GetCacheId method.

Needs investigation.

See https://github.com/Archomeda/Gw2Sharp/blob/master/Gw2Sharp/WebApi/Middleware/CacheMiddleware.cs#L67-L80=