Fix: did not get version number when gw2sharp.dll was included into .… - Githubissues

Archomeda / Gw2Sharp

A cross-platform .NET wrapper library for the Guild Wars 2 API written in C#

https://archomeda.github.io/Gw2Sharp

MIT License

37 stars 8 forks source link

Fix: did not get version number when gw2sharp.dll was included into .… #125

Closed Taschenbuch closed 2 years ago

Taschenbuch commented 2 years ago

…exe with fody costura

fody costura wraps all .dlls into a single .exe. Because of that the gw2sharp.dll was not accessible. Thus the assembly.Location returned an empty string. This empty string caused .GetVersionInfo to throw a 'System.ArgumentException' in mscorlib.dll with System.ArgumentException: 'The path is not of a legal form.'
fody costura is used by BlishHud for example
try catch is probably not necessary anymore?

sources