Report by Niklp: collect circular saw bugs

[Archtec-Bot]

Report by Niklp:

collect circular saw bugs

Position:

{
    x = -418.47299194336,
    y = 9.5,
    z = 275.16497802734
}

Meta:

{
    fields = {
        cart_pos = "(-385,6,296)",
        bone_waypoints = "return {}",
        towercrane_isoperator = "0",
        ["ambience.svol"] = "1",
        ["stairsplus:max_offered"] = "99",
        ["sethome:home"] = "(305.96798706055,44.5,-1937.9759521484)",
        ["alternode:node"] = "return {name=\"archtec:sign_wall_steel_white_black\",param1=136,param2=2}",
        techage_collider_number = "2549",
        ["signslib:pos"] = "(306,24,-2642)",
        ["3d_armor_inventory"] = "return {\"\",\"invisible_shields:shield_mithril 1 33816\",\"\",\"invisible_3d_armor:leggings_mithril 1 33816\",\"invisible_3d_armor:helmet_mithril 1 24803\",\"invisible_3d_armor:chestplate_mithril 1 33816\"}",
        ["stamina:level"] = "20",
        autobahn_isactive = "0",
        ["stamina:exhaustion"] = "0",
        techage_ex_points = "61",
        ["stairsplus:shape_groups"] = "[\"legacy\"]",
        ["chatplus:namecolor"] = "c",
        ["customskins:skin"] = "return {bodyA=\"body1_default.png\",bodyB=\"body2_8.png\",hair=\"hair_default.png\",misc=\"misc_2.png\",base=\"skin_default.png\",shoes=\"shoes_default.png\",face=\"face_default.png\",legs=\"legs_3.png\"}",
        has_placed_stocking = "1",
        player_physics_locked = "0",
        techage_forceload_blocks = "return {{x=-386,y=6,z=294},{x=-428,y=10,z=271}}",
        techage_screwdriver_param2 = "4",
        ["unified_inventory:bags"] = "r1=\"unified_inventory:bag_large\";return {r1,r1,r1,r1}"
    }
}

Server status:

Archtec: version: 5.8.0 | uptime: 1d 19h 4min 45s | max lag: 0.09s | clients (2/20): Niklp, Zwurgel

[Niklp09]

Bug no1: items can "disappear" when using SHIFT

1. get 2 full stacks of default:stonebrick
2. SHIFT+click move one of those into the saw
3. SHIFT+click move twice on default:slope_stonebrick_half_raised -> result: 99+33 of those
4. SHIFT+click second stonebrick stack into saw
5. SHIFT+click move twice on default:slope_stonebrick_half_raised -> result: just 99 of those, the 33 are lost

Bug no2: the saw creates stacks w/ a size of 65480 nodes

1. no repro yet, but happend already to >3 players

[fluxionary]

the first bug may or may not be an engine bug, i created an upstream issue: https://github.com/minetest/minetest/issues/14210

[fluxionary]

the second bug feels like an underflow, it might be due to the same underlying misunderstanding of stack sizes.

[Niklp09]

bug no.1 should be fixed upstream via https://github.com/minetest/minetest/commit/4245a7604b96b516b747e22f1410dee825922af1.

Edit: Tested locally, works fine.

[Niklp09]

Bug no.1 definitely fixed, bug no.2 was probably caused by no.1.