search

Archtec-io / bugtracker

0 stars 0 forks source link

Replace `meta:set_string(*, nil)` calls #190

Closed Niklp09 closed 2 months ago

Niklp09 commented 3 months ago

tl;dr: meta:set_string(*, nil) was never documented and is deprecated in mt 5.9. We have to replace nil w/ "" to delete keys in meta.

This is what grep found:

$ grep -rE "set_string(.*nil)"
minetest_game/default/chests.lua:                               meta:set_string("formspec", nil)
signs_bot/tool.lua:             meta:set_string("signs_bot_spos", nil)
signs_bot/tool.lua:             meta:set_string("signs_bot_name", nil)
tubelib2/internal1.lua: meta:set_string("channel", nil)
tubelib2/internal1.lua: meta:set_string("formspec", nil)
tubelib2/internal2.lua: meta:set_string("channel", nil)
tubelib2/internal2.lua: meta:set_string("formspec", nil)
tubelib2/tube_api.lua:          meta:set_string("channel", nil)
tubelib2/tube_api.lua:                          peer_meta:set_string("channel", nil)
tubelib2/tube_api.lua:                          peer_meta:set_string("tele_pos", nil)
unified_inventory/bags.lua:             meta:set_string("unified_inventory:bags", nil)
techage/icta_controller/controller.lua:         --meta:set_string("formspec", techage.cond_formspec(1, 1, nil))
techage/logic/button.lua:               meta:set_string("formspec", nil)
techage/logic/programmer.lua:   user:get_meta():set_string("techage_prog_numbers", nil)
techage/logic/programmer.lua:           placer:get_meta():set_string("techage_prog_numbers", nil)
techage/logic/terminal.lua:                     meta:set_string("number", nil)
techage/move_controller/doorblock.lua:                          meta:set_string("formspec", nil)
techage/move_controller/gateblock.lua:                          meta:set_string("formspec", nil)

IIRC the calls w/ variables which are nil must be fixed on the fly :confused:.

Niklp09 commented 2 months ago

Closing this since all obvious cases are fixed.