Archy-X / AuraSkills

The ultra-versatile RPG skills plugin
https://aurelium.dev/auraskills
GNU General Public License v3.0
239 stars 92 forks source link

"Alchemist" Duration Increase allows multiple durations to be stored on one potion #278

Closed RelinquishMental closed 4 months ago

RelinquishMental commented 5 months ago

Server software and version

Paper 1.20.6

Expected behavior

When I begin a new brew cycle, I expect any completed potions that have been left in the stand to remain unaltered by the new brewing.

I expect the same behavior as vanilla.

Actual behavior

When I begin a new brew cycle, somehow any completed potions that have been left in the stand receive another increased Alchemist duration applied to their tooltip.

Eventually this makes the game think that there are multiple potions in the stand, and when I interact with the potions or the stand, I get kicked by NBT tag too large errors

How to reproduce

Give yourself Alchemy 1000. (I had alchemy mid 400s, but any high value should reproduce)

Brew potions with a duration, but only remove 1 potion from the brew stand, leaving 2 completed potions.

Repeat this to get multiple durations on one pot, to confirm the bug.

If you repeat until you get many durations (more than can be viewed on screen), you will eventually run into the "NBT tag too large issue", as well.

Additional information

Is this something you have seen before?

Agreements

Archy-X commented 4 months ago

This has been fixed in 2.1.0.

RelinquishMental commented 4 months ago

Awesome thanks